Re: [Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

2016-05-04 Thread Chris Wilson
On Wed, May 04, 2016 at 12:35:09PM +0100, Dave Gordon wrote: >On 29/04/2016 09:49, Chris Wilson wrote: > > On Fri, Apr 29, 2016 at 09:36:37AM +0100, Tvrtko Ursulin wrote: > > On 28/04/16 17:24, Chris Wilson wrote: > > With the introduction of a distinct engine->id vs the hardware id, we n

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

2016-05-04 Thread Dave Gordon
On 29/04/2016 09:49, Chris Wilson wrote: On Fri, Apr 29, 2016 at 09:36:37AM +0100, Tvrtko Ursulin wrote: On 28/04/16 17:24, Chris Wilson wrote: With the introduction of a distinct engine->id vs the hardware id, we need to fix up the value we use for selecting the target engine when signaling a

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

2016-04-29 Thread Chris Wilson
On Fri, Apr 29, 2016 at 09:36:37AM +0100, Tvrtko Ursulin wrote: > > On 28/04/16 17:24, Chris Wilson wrote: > >With the introduction of a distinct engine->id vs the hardware id, we need > >to fix up the value we use for selecting the target engine when signaling > >a semaphore. Note that these valu

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

2016-04-29 Thread Tvrtko Ursulin
On 28/04/16 17:24, Chris Wilson wrote: With the introduction of a distinct engine->id vs the hardware id, we need to fix up the value we use for selecting the target engine when signaling a semaphore. Note that these values can be merged with engine->guc_id. So I broke something more with the

[Intel-gfx] [PATCH 03/10] drm/i915: Fix gen8 semaphores id for legacy mode

2016-04-28 Thread Chris Wilson
With the introduction of a distinct engine->id vs the hardware id, we need to fix up the value we use for selecting the target engine when signaling a semaphore. Note that these values can be merged with engine->guc_id. Fixes: de1add360522c876c25ef2ab1c94bdb509ab Signed-off-by: Chris Wilson C