Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-30 Thread Jani Nikula
On Thu, 29 Oct 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We get spurious PCH FIFO underruns if we enable the reporting too soon > after enabling the crtc. Move it to be the last step, after the encoder > enable. Additionally we need an

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-30 Thread Ville Syrjälä
On Fri, Oct 30, 2015 at 12:06:09PM +0200, Jani Nikula wrote: > On Thu, 29 Oct 2015, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We get spurious PCH FIFO underruns if we enable the reporting too soon > > after enabling the crtc. Move it to be

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-30 Thread Jani Nikula
On Fri, 30 Oct 2015, Ville Syrjälä wrote: > On Fri, Oct 30, 2015 at 12:06:09PM +0200, Jani Nikula wrote: >> On Thu, 29 Oct 2015, ville.syrj...@linux.intel.com wrote: >> > From: Ville Syrjälä >> > >> > We get spurious PCH FIFO

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-30 Thread Daniel Vetter
On Thu, Oct 29, 2015 at 11:21:28PM +0200, Ville Syrjälä wrote: > On Thu, Oct 29, 2015 at 05:57:57PM -0200, Paulo Zanoni wrote: > > 2015-10-29 17:25 GMT-02:00 : > > > From: Ville Syrjälä > > > > > > We get spurious PCH FIFO underruns

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-30 Thread Daniel Vetter
On Fri, Oct 30, 2015 at 02:08:51PM +0200, Ville Syrjälä wrote: > On Fri, Oct 30, 2015 at 12:06:09PM +0200, Jani Nikula wrote: > > On Thu, 29 Oct 2015, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > We get spurious PCH FIFO underruns if we

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-29 Thread Paulo Zanoni
2015-10-29 17:25 GMT-02:00 : > From: Ville Syrjälä > > We get spurious PCH FIFO underruns if we enable the reporting too soon > after enabling the crtc. Move it to be the last step, after the encoder > enable. Additionally we need an

[Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-29 Thread ville . syrjala
From: Ville Syrjälä We get spurious PCH FIFO underruns if we enable the reporting too soon after enabling the crtc. Move it to be the last step, after the encoder enable. Additionally we need an extra vblank wait, otherwise we still get the underruns. Presumably

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-29 Thread Jesse Barnes
On 10/29/2015 12:25 PM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We get spurious PCH FIFO underruns if we enable the reporting too soon > after enabling the crtc. Move it to be the last step, after the encoder > enable. Additionally we need an

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Enable PCH FIFO underruns later on ILK/SNB/IVB

2015-10-29 Thread Ville Syrjälä
On Thu, Oct 29, 2015 at 05:57:57PM -0200, Paulo Zanoni wrote: > 2015-10-29 17:25 GMT-02:00 : > > From: Ville Syrjälä > > > > We get spurious PCH FIFO underruns if we enable the reporting too soon > > after enabling the crtc. Move it