Re: [Intel-gfx] [PATCH 03/16] drm/i915: Extract intel_dp_use_bigjoiner()

2021-09-21 Thread Navare, Manasi
On Mon, Sep 13, 2021 at 05:44:27PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Suck the "do we need bigjoiner?" checks into a helper instead of > duplicating them in two differentt places. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- >

Re: [Intel-gfx] [PATCH 03/16] drm/i915: Extract intel_dp_use_bigjoiner()

2021-09-15 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 01:12:26PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Suck the "do we need bigjoiner?" checks into a helper instead of > > duplicating them in two differentt places. > > Could've called it

Re: [Intel-gfx] [PATCH 03/16] drm/i915: Extract intel_dp_use_bigjoiner()

2021-09-15 Thread Jani Nikula
On Mon, 13 Sep 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Suck the "do we need bigjoiner?" checks into a helper instead of > duplicating them in two differentt places. Could've called it intel_dp_need_bigjoiner() but meh. Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH 03/16] drm/i915: Extract intel_dp_use_bigjoiner()

2021-09-13 Thread Ville Syrjala
From: Ville Syrjälä Suck the "do we need bigjoiner?" checks into a helper instead of duplicating them in two differentt places. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git