Re: [Intel-gfx] [PATCH 04/12] drm/i915/fbc: Fix nuke for pre-snb platforms

2020-05-04 Thread Ville Syrjälä
On Fri, May 01, 2020 at 06:18:18PM -0700, Matt Roper wrote: > On Wed, Apr 29, 2020 at 01:10:26PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The MSG_FBC_REND_STATE register only exists on snb+. For older > > I only find this register in the bspec for HSW+. Is the spec

Re: [Intel-gfx] [PATCH 04/12] drm/i915/fbc: Fix nuke for pre-snb platforms

2020-05-01 Thread Matt Roper
On Wed, Apr 29, 2020 at 01:10:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The MSG_FBC_REND_STATE register only exists on snb+. For older I only find this register in the bspec for HSW+. Is the spec incomplete or am I looking in the wrong place? It's a bit hard to review these

[Intel-gfx] [PATCH 04/12] drm/i915/fbc: Fix nuke for pre-snb platforms

2020-04-29 Thread Ville Syrjala
From: Ville Syrjälä The MSG_FBC_REND_STATE register only exists on snb+. For older platforms (would also work for snb+) we can simply rewite DSPSURF to trigger a flip nuke. While generally RMW is considered harmful we'll use it here for simplicity. And since FBC doesn't exist in i830 we don't