Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:38PM -0700, Keith Packard wrote: Avoid any question about locked registers by just writing the unlock pattern with every write to the register. Signed-off-by: Keith Packard kei...@keithp.com grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the

Re: [Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:09:46 +0200, Daniel Vetter dan...@ffwll.ch wrote: grep shows that we also write to PCH_PP_CONTROL in intel_lvds.c in the dpms functions - any reasons these two writes are left out? Upon a bit of review: The bspec makes it clear that this write protect key only needs

[Intel-gfx] [PATCH 06/21] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-29 Thread Keith Packard
Avoid any question about locked registers by just writing the unlock pattern with every write to the register. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 14 +- 2 files changed, 14 insertions(+), 1