Re: [Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-23 Thread Chris Wilson
Quoting Stuart Summers (2019-08-23 17:03:03) > Add a subslice stride calculation when setting subslices. This > aligns more closely with the userspace expectation of the subslice > mask structure. > > v2: Use local variable for subslice_mask on HSW and > clean up a few other subslice_mask

[Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-23 Thread Stuart Summers
Add a subslice stride calculation when setting subslices. This aligns more closely with the userspace expectation of the subslice mask structure. v2: Use local variable for subslice_mask on HSW and clean up a few other subslice_mask local variable changes v3: Add GEM_BUG_ON for ss_stride

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-23 Thread Summers, Stuart
On Thu, 2019-08-22 at 23:43 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-22 19:32:09) > > Add a subslice stride calculation when setting subslices. This > > aligns more closely with the userspace expectation of the subslice > > mask structure. > > > > v2: Use local variable for

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-22 Thread Chris Wilson
Quoting Stuart Summers (2019-08-22 19:32:09) > Add a subslice stride calculation when setting subslices. This > aligns more closely with the userspace expectation of the subslice > mask structure. > > v2: Use local variable for subslice_mask on HSW and > clean up a few other subslice_mask

[Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-22 Thread Stuart Summers
Add a subslice stride calculation when setting subslices. This aligns more closely with the userspace expectation of the subslice mask structure. v2: Use local variable for subslice_mask on HSW and clean up a few other subslice_mask local variable changes v3: Add GEM_BUG_ON for ss_stride

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-22 Thread Summers, Stuart
On Wed, 2019-08-21 at 23:36 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-08-21 00:05:40) > > Add a subslice stride calculation when setting subslices. This > > aligns more closely with the userspace expectation of the subslice > > mask structure. > > > > v2: Use local variable for

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-21 Thread Chris Wilson
Quoting Stuart Summers (2019-08-21 00:05:40) > Add a subslice stride calculation when setting subslices. This > aligns more closely with the userspace expectation of the subslice > mask structure. > > v2: Use local variable for subslice_mask on HSW and > clean up a few other subslice_mask

[Intel-gfx] [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice

2019-08-20 Thread Stuart Summers
Add a subslice stride calculation when setting subslices. This aligns more closely with the userspace expectation of the subslice mask structure. v2: Use local variable for subslice_mask on HSW and clean up a few other subslice_mask local variable changes v3: Add GEM_BUG_ON for ss_stride