Re: [Intel-gfx] [PATCH 07/21] drm/i915: Check for eDP inside intel_edp_panel_vdd_on/off

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:39PM -0700, Keith Packard wrote: Cleans up code dealing with eDP VDD a bit. Remove redundant checks in callers Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files changed, 10 insertions(+),

Re: [Intel-gfx] [PATCH 07/21] drm/i915: Check for eDP inside intel_edp_panel_vdd_on/off

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:13:55 +0200, Daniel Vetter dan...@ffwll.ch wrote: Why not also move the id_edp check into edp_panel_on|off like for the vdd functions? This way it looks a bit inconsistent ... Yeah, I can do that. May mean a few redundant checks, but they're cheap. --

[Intel-gfx] [PATCH 07/21] drm/i915: Check for eDP inside intel_edp_panel_vdd_on/off

2011-09-29 Thread Keith Packard
Cleans up code dealing with eDP VDD a bit. Remove redundant checks in callers Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c