Re: [Intel-gfx] [PATCH 07/55] drm/i915: Avoid using intel_engine_cs *ring for GPU error capture

2016-07-27 Thread Joonas Lahtinen
On ti, 2016-07-26 at 09:19 +0100, Chris Wilson wrote: > On Tue, Jul 26, 2016 at 07:59:29AM +0300, Joonas Lahtinen wrote: > > > > On ma, 2016-07-25 at 18:31 +0100, Chris Wilson wrote: > > > > > > > > Inside the error capture itself, we refer to not only the hardware > > > engine, its ringbuffer

Re: [Intel-gfx] [PATCH 07/55] drm/i915: Avoid using intel_engine_cs *ring for GPU error capture

2016-07-26 Thread Chris Wilson
On Tue, Jul 26, 2016 at 07:59:29AM +0300, Joonas Lahtinen wrote: > On ma, 2016-07-25 at 18:31 +0100, Chris Wilson wrote: > > > Inside the error capture itself, we refer to not only the hardware > > engine, its ringbuffer but also the capture state. Finding clear names > > for each whilst avoiding

Re: [Intel-gfx] [PATCH 07/55] drm/i915: Avoid using intel_engine_cs *ring for GPU error capture

2016-07-25 Thread Joonas Lahtinen
On ma, 2016-07-25 at 18:31 +0100, Chris Wilson wrote: > Inside the error capture itself, we refer to not only the hardware > engine, its ringbuffer but also the capture state. Finding clear names > for each whilst avoiding mixing ring/intel_engine_cs is tricky. As a > compromise we keep using

[Intel-gfx] [PATCH 07/55] drm/i915: Avoid using intel_engine_cs *ring for GPU error capture

2016-07-25 Thread Chris Wilson
Inside the error capture itself, we refer to not only the hardware engine, its ringbuffer but also the capture state. Finding clear names for each whilst avoiding mixing ring/intel_engine_cs is tricky. As a compromise we keep using ering for the error capture. Signed-off-by: Chris Wilson