Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-11-06 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:50:12 +0300 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Sep 11, 2014 at 07:15:27AM -0700, Jesse Barnes wrote: On Thu, 11 Sep 2014 14:59:35 +0300 Imre Deak imre.d...@intel.com wrote: On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed,

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-10-21 Thread Ville Syrjälä
On Thu, Sep 11, 2014 at 07:15:27AM -0700, Jesse Barnes wrote: On Thu, 11 Sep 2014 14:59:35 +0300 Imre Deak imre.d...@intel.com wrote: On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: Since correctness wins over optimal

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-09-11 Thread Chris Wilson
On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: Since correctness wins over optimal code and since the optimization Optimal code is also correct ;-) s/optimal/just plain broken/ -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-09-11 Thread Daniel Vetter
On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: The logic to skip restoring GTT mappings was added to speed up suspend/resume, but not on old GENs where not restoring them caused problems. The check for old GENs is based on the existance of OpRegion, but this doesn't work since

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-09-11 Thread Imre Deak
On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: Since correctness wins over optimal code and since the optimization Optimal code is also correct ;-) s/optimal/just plain broken/ Yes, bad wording. To clarify, since the

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-09-11 Thread Jesse Barnes
On Thu, 11 Sep 2014 14:59:35 +0300 Imre Deak imre.d...@intel.com wrote: On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: Since correctness wins over optimal code and since the optimization Optimal code is also correct ;-)

[Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-09-10 Thread Imre Deak
The logic to skip restoring GTT mappings was added to speed up suspend/resume, but not on old GENs where not restoring them caused problems. The check for old GENs is based on the existance of OpRegion, but this doesn't work since opregion is initialized only after the check. So we end up always