Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

2014-04-16 Thread Egbert Eich
Daniel Vetter writes: Hm, I think to address Chris' concern we should split this into two pieces: connector_break_all links which only breaks connector-encoder stuff, used in both places as is. And a new encoder_break_all links which we'll use in sanitize_crtc in a new encoder loop.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

2014-04-15 Thread Chris Wilson
On Mon, Apr 14, 2014 at 07:26:08PM +0200, Egbert Eich wrote: Depending on the SDVO output_flags SDVO may have multiple connectors linking to the same encoder (in intel_connector-encoder-base). Only one of those connectors should be active (ie link to the encoder thru drm_connector-encoder. If

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

2014-04-15 Thread Egbert Eich
Chris Wilson writes: On Mon, Apr 14, 2014 at 07:26:08PM +0200, Egbert Eich wrote: Depending on the SDVO output_flags SDVO may have multiple connectors linking to the same encoder (in intel_connector-encoder-base). Only one of those connectors should be active (ie link to the encoder

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

2014-04-15 Thread Daniel Vetter
On Mon, Apr 14, 2014 at 07:26:08PM +0200, Egbert Eich wrote: Depending on the SDVO output_flags SDVO may have multiple connectors linking to the same encoder (in intel_connector-encoder-base). Only one of those connectors should be active (ie link to the encoder thru drm_connector-encoder. If

[Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

2014-04-14 Thread Egbert Eich
Depending on the SDVO output_flags SDVO may have multiple connectors linking to the same encoder (in intel_connector-encoder-base). Only one of those connectors should be active (ie link to the encoder thru drm_connector-encoder. If intel_connector_break_all_links() is called from