Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Sean Paul
On Tue, Sep 27, 2016 at 12:54 PM, Emil Velikov wrote: > On 27 September 2016 at 17:43, Joe Perches wrote: >> On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: >>> On 27 September 2016 at 17:04, Joe Perches wrote: >>> > On Tue,

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: > On 27 September 2016 at 17:04, Joe Perches wrote: > > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > > > Use a bit more consistent

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Emil Velikov
On 27 September 2016 at 17:43, Joe Perches wrote: > On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: >> On 27 September 2016 at 17:04, Joe Perches wrote: >> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: >> > > On Sun, Sep 25, 2016 at 10:18 PM,

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: > On 27 September 2016 at 17:04, Joe Perches wrote: > > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > > > Use a bit more consistent

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Emil Velikov
On 27 September 2016 at 17:04, Joe Perches wrote: > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: >> > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: >> > Use a bit more consistent style with kernel loglevels >> > I'm not convinced this is worth

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > Use a bit more consistent style with kernel loglevels > > I'm not convinced this is worth doing if we're going to keep the > WARN/WARNING discrepancy, and I don't

Re: [Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Sean Paul
On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > Use a bit more consistent style with kernel loglevels I'm not convinced this is worth doing if we're going to keep the WARN/WARNING discrepancy, and I don't think we should switch DRM_WARN to DRM_WARNING since it's so

[Intel-gfx] [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-25 Thread Joe Perches
Use a bit more consistent style with kernel loglevels without using macro argument concatenation. Miscellanea: o Single statement macros don't need do {} while (0) Signed-off-by: Joe Perches --- drivers/gpu/drm/i915/intel_guc_loader.c | 22 --