Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset

2020-06-03 Thread Daniel Vetter
On Wed, Jun 3, 2020 at 2:19 AM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > May I remind you about the -v option to git-format-patch ? :-) Seriously > speaking, it really helps review. > > On Tue, Jun 02, 2020 at 11:51:38AM +0200, Daniel Vetter wrote: > > Only when

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset

2020-06-02 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. May I remind you about the -v option to git-format-patch ? :-) Seriously speaking, it really helps review. On Tue, Jun 02, 2020 at 11:51:38AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most

[Intel-gfx] [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset

2020-06-02 Thread Daniel Vetter
Only when vblanks are supported ofc. Some drivers do this already, but most unfortunately missed it. This opens up bugs after driver load, before the crtc is enabled for the first time. syzbot spotted this when loading vkms as a secondary output. Given how many drivers are buggy it's best to