Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-09-07 Thread Dhinakaran Pandiyan
On Fri, 2018-09-07 at 17:32 +0300, Ville Syrjälä wrote: > On Fri, Sep 07, 2018 at 03:39:24PM +0300, Jani Nikula wrote: > > On Thu, 06 Sep 2018, Dhinakaran Pandiyan > .com> wrote: > > > Comment claims link needs to be retrained because the connected > > > sink raised > > > a long pulse to indicate

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-09-07 Thread Manasi Navare
On Fri, Sep 07, 2018 at 05:32:36PM +0300, Ville Syrjälä wrote: > On Fri, Sep 07, 2018 at 03:39:24PM +0300, Jani Nikula wrote: > > On Thu, 06 Sep 2018, Dhinakaran Pandiyan > > wrote: > > > Comment claims link needs to be retrained because the connected sink > > > raised > > > a long pulse to

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-09-07 Thread Ville Syrjälä
On Fri, Sep 07, 2018 at 03:39:24PM +0300, Jani Nikula wrote: > On Thu, 06 Sep 2018, Dhinakaran Pandiyan > wrote: > > Comment claims link needs to be retrained because the connected sink raised > > a long pulse to indicate link loss. If the sink did so, > > intel_dp_hotplug() would have handled

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-09-07 Thread Jani Nikula
On Thu, 06 Sep 2018, Dhinakaran Pandiyan wrote: > Comment claims link needs to be retrained because the connected sink raised > a long pulse to indicate link loss. If the sink did so, > intel_dp_hotplug() would have handled link retraining. Looking at the > logs in Bugzilla referenced in commit

[Intel-gfx] [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-09-07 Thread Dhinakaran Pandiyan
Comment claims link needs to be retrained because the connected sink raised a long pulse to indicate link loss. If the sink did so, intel_dp_hotplug() would have handled link retraining. Looking at the logs in Bugzilla referenced in commit '3cf71bc9904d ("drm/i915: Re-apply Perform link quality