Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-24 Thread Joonas Lahtinen
On ke, 2015-06-24 at 09:55 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Also it was misleading to log view size as object size. v2: Improve commit message. (Joonas Lahtinen) Reviewed-by:

[Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Also it was misleading to log view size as object size. v2: Improve commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-24 Thread Joonas Lahtinen
On ti, 2015-06-23 at 12:57 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Comment below. Reviewed-by: Joonas Lahtinen joonas.lahti...@linux.intel.com Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-24 Thread Tvrtko Ursulin
On 06/24/2015 08:38 AM, Joonas Lahtinen wrote: On ti, 2015-06-23 at 12:57 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Comment below. Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Joonas Lahtinen joonas.lahti...@linux.intel.com --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +++ 1 file changed, 3

[Intel-gfx] [PATCH 1/3] drm/i915: Remove mostly unused variable in intel_rotate_fb_obj_pages

2015-06-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com It is only used in logging and it doesn't need to exist on its own. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Joonas Lahtinen joonas.lahti...@linux.intel.com --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +++ 1 file changed, 3