Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Andi Shyti
Hi Ram, Reviewed-by: Andi Shyti but just two notes on the patchstyle, no need to resend: 1. would be nice to have [PATCH v2...] otherwise it's difficult to see if I'm reading the correct version. (I don't see the difficulty 'git format-patch -v 2...') > Add a new platform flag,

[Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Ramalingam C
From: Stuart Summers Add a new platform flag, has_64k_pages, to mark the requirement of 64K GTT page sizes or larger for device local memory access. Also implies that we require or at least support the compact PT layout for the ppGTT when using 64K GTT pages. v2: More explanation for the flag

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Intel
On 12/8/21 13:59, Matthew Auld wrote: On Wed, 8 Dec 2021 at 12:43, Thomas Hellström (Intel) wrote: Hi, On 12/7/21 17:51, Ramalingam C wrote: From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Matthew Auld
On Wed, 8 Dec 2021 at 12:43, Thomas Hellström (Intel) wrote: > > Hi, > > On 12/7/21 17:51, Ramalingam C wrote: > > From: Stuart Summers > > > > Add a new platform flag, has_64k_pages, for platforms supporting > > base page sizes of 64k. > > > > Signed-off-by: Stuart Summers > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Intel
Hi, On 12/7/21 17:51, Ramalingam C wrote: From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-07 Thread Ramalingam C
From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c