Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-15 Thread Daniel Vetter
On Fri, Sep 12, 2014 at 05:29:44PM -0700, Rodrigo Vivi wrote: Please ignore this full series here. I have a better one that let PSR on HSW in a better stage with only 1 idle frame and without changing the 100ms. Actually if we are brave we can reduce this to 24 or less. The new work is

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-12 Thread Rodrigo Vivi
Please ignore this full series here. I have a better one that let PSR on HSW in a better stage with only 1 idle frame and without changing the 100ms. Actually if we are brave we can reduce this to 24 or less. The new work is currently under

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-05 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 05:40:05PM -0700, Rodrigo Vivi wrote: Here goes results on BDW with pure today's nightly (with idle_frame=1) # First run IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64) Subtest primary_page_flip: SUCCESS Subtest primary_mmap_gtt: SUCCESS Test

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Ville Syrjälä
On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is safier. This idle frame detection still depends of FBC right? I believe

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Jani Nikula
On Thu, 04 Sep 2014, Rodrigo Vivi rodrigo.v...@intel.com wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is safier. Discovered and validated with refactored igt/kms_sink_psr_crc.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is safier. Discovered and validated with refactored igt/kms_sink_psr_crc.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Ville Syrjälä
On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote: On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Ville Syrjälä
On Thu, Sep 04, 2014 at 01:04:27PM +0300, Ville Syrjälä wrote: On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote: On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 01:18:19PM +0300, Ville Syrjälä wrote: On Thu, Sep 04, 2014 at 01:04:27PM +0300, Ville Syrjälä wrote: On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote: On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote: On Wed, Sep 03, 2014 at 10:49:56PM

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 12:55 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 1:09 AM, Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 04 Sep 2014, Rodrigo Vivi rodrigo.v...@intel.com wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 3:04 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote: On Thu, Sep 04, 2014 at 10:55:16AM +0300, Ville Syrjälä wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 4:04 AM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Sep 04, 2014 at 01:18:19PM +0300, Ville Syrjälä wrote: On Thu, Sep 04, 2014 at 01:04:27PM +0300, Ville Syrjälä wrote: On Thu, Sep 04, 2014 at 11:29:16AM +0200, Daniel Vetter wrote: On Thu, Sep 04, 2014 at

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Daniel Vetter
On Thu, Sep 4, 2014 at 8:20 PM, Rodrigo Vivi rodrigo.v...@gmail.com wrote: On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With Software tracking we are going to PSR sooner than we should and staying with

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
On Thu, Sep 4, 2014 at 12:05 PM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Sep 4, 2014 at 8:20 PM, Rodrigo Vivi rodrigo.v...@gmail.com wrote: On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote: With

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Daniel Vetter
On Thu, Sep 4, 2014 at 9:16 PM, Rodrigo Vivi rodrigo.v...@gmail.com wrote: Hm, I don't see a pattern at all. And that sprites seem to work best also looks funky. Are the results stable when you randomize them (piglit can do that for you)? Can you add a residency checks in the testcase (i.e.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-04 Thread Rodrigo Vivi
Here goes results on BDW with pure today's nightly (with idle_frame=1) # First run IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64) Subtest primary_page_flip: SUCCESS Subtest primary_mmap_gtt: SUCCESS Test assertion failure function test_crc, file kms_psr_sink_crc.c:307: Failed

[Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-03 Thread Rodrigo Vivi
With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is safier. Discovered and validated with refactored igt/kms_sink_psr_crc. Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com ---