Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-18 Thread Jani Nikula
On Fri, 15 Aug 2014, Imre Deak wrote: > On Fri, 2014-08-15 at 12:48 +0300, Jani Nikula wrote: >> On Fri, 15 Aug 2014, Imre Deak wrote: >> > On Wed, 2014-08-13 at 19:33 +0300, Ville Syrjälä wrote: >> >> The series seems fine to me. >> >> >> >> Reviewed-by: Ville Syrjälä >> >> for the rest as wel

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-15 Thread Imre Deak
On Fri, 2014-08-15 at 12:48 +0300, Jani Nikula wrote: > On Fri, 15 Aug 2014, Imre Deak wrote: > > On Wed, 2014-08-13 at 19:33 +0300, Ville Syrjälä wrote: > >> The series seems fine to me. > >> > >> Reviewed-by: Ville Syrjälä > >> for the rest as well. > > > > Thanks, I assume it's for v2. I'd sa

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-15 Thread Jani Nikula
On Fri, 15 Aug 2014, Imre Deak wrote: > On Wed, 2014-08-13 at 19:33 +0300, Ville Syrjälä wrote: >> The series seems fine to me. >> >> Reviewed-by: Ville Syrjälä >> for the rest as well. > > Thanks, I assume it's for v2. I'd say this is for -fixes. The problem > existed even in 3.16, but only the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-15 Thread Imre Deak
On Wed, 2014-08-13 at 19:33 +0300, Ville Syrjälä wrote: > The series seems fine to me. > > Reviewed-by: Ville Syrjälä > for the rest as well. Thanks, I assume it's for v2. I'd say this is for -fixes. The problem existed even in 3.16, but only the MST support made it apparent with the extra HPD s

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-13 Thread Ville Syrjälä
The series seems fine to me. Reviewed-by: Ville Syrjälä for the rest as well. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-11 Thread Imre Deak
Atm, the HPD IRQ reenable timer can get rearmed right after it's canceled. Also to access the HPD IRQ mask registers we need to wake up the HW. Solve both issues by converting the reenable timer to a delayed work and grabbing a runtime PM reference in the work. By this we can also forgo canceling