Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-10 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com On 11/06/2014 12:26 AM, Jesse Barnes wrote: This allows us to calculate the full pipe config before we do any mode setting work. v2: - clarify comments about global vs. per-crtc mode set (Ander) - clean up

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-06 Thread Chris Wilson
On Wed, Nov 05, 2014 at 02:26:06PM -0800, Jesse Barnes wrote: +static int intel_set_mode(struct drm_crtc *crtc, + struct drm_display_mode *mode, + int x, int y, struct drm_framebuffer *fb) +{ + struct intel_crtc_config *pipe_config; +

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 09:04:14AM +, Chris Wilson wrote: On Wed, Nov 05, 2014 at 02:26:06PM -0800, Jesse Barnes wrote: +static int intel_set_mode(struct drm_crtc *crtc, + struct drm_display_mode *mode, + int x, int y, struct drm_framebuffer *fb)

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-05 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. v2: - clarify comments about global vs. per-crtc mode set (Ander) - clean up unnecessary pipe_config = NULL setting (Ander) v3: - fix pipe_config handling (alloc in compute_config, free in set_mode) (Jesse)

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-11-03 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 11:38:20AM -0700, Jesse Barnes wrote: On Wed, 29 Oct 2014 16:30:43 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: +static int intel_modeset_compute_config(struct drm_crtc *crtc, s/drm_crtc/intel_crtc/

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2

2014-10-31 Thread Jesse Barnes
Thanks for the review, Ander. Daniel, in case you're tempted to merge this, don't just yet. Shaung's test bot found an issue with the refactoring patch I'm still tracking down. I'll post a v3 with the fix in reply to this... Thanks, Jesse On Thu, 30 Oct 2014 11:53:59 -0700 Jesse Barnes

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-10-30 Thread Jesse Barnes
On Wed, 29 Oct 2014 16:30:43 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2

2014-10-30 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. v2: - clarify comments about global vs. per-crtc mode set (Ander) - clean up unnecessary pipe_config = NULL setting (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-10-29 Thread Ander Conselvan de Oliveira
On 10/23/2014 09:50 PM, Jesse Barnes wrote: This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 93 +--- 1 file changed, 65

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-10-23 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 93 +--- 1 file changed, 65 insertions(+), 28 deletions(-) diff --git