Re: [Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-06 Thread Jesse Barnes
On Thu, 6 Mar 2014 09:35:23 + Chris Wilson wrote: > On Wed, Mar 05, 2014 at 02:48:26PM -0800, Jesse Barnes wrote: > > @@ -7554,6 +7610,8 @@ static int intel_crtc_cursor_set(struct drm_crtc > > *crtc, > > goto fail; > > } > > > > + intel_sync_crtc(crtc); > > + > > /* w

Re: [Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-06 Thread Chris Wilson
On Wed, Mar 05, 2014 at 02:48:26PM -0800, Jesse Barnes wrote: > @@ -7554,6 +7610,8 @@ static int intel_crtc_cursor_set(struct drm_crtc *crtc, > goto fail; > } > > + intel_sync_crtc(crtc); > + > /* we only need to pin inside GTT if cursor is non-phy */ > mutex_l

Re: [Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-05 Thread Imre Deak
On Wed, 2014-03-05 at 15:39 -0800, Jesse Barnes wrote: > On Thu, 06 Mar 2014 01:29:14 +0200 > Imre Deak wrote: > > > On Wed, 2014-03-05 at 14:48 -0800, Jesse Barnes wrote: > > > This lets us return to userspace more quickly and should improve init > > > and suspend/resume times as well, allowing

Re: [Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-05 Thread Jesse Barnes
On Thu, 06 Mar 2014 01:29:14 +0200 Imre Deak wrote: > On Wed, 2014-03-05 at 14:48 -0800, Jesse Barnes wrote: > > This lets us return to userspace more quickly and should improve init > > and suspend/resume times as well, allowing us to return to userspace > > sooner. > > IMHO this is a good move

Re: [Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-05 Thread Imre Deak
On Wed, 2014-03-05 at 14:48 -0800, Jesse Barnes wrote: > This lets us return to userspace more quickly and should improve init > and suspend/resume times as well, allowing us to return to userspace > sooner. IMHO this is a good move towards a full command queue based solution for kms commands, whe

[Intel-gfx] [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous

2014-03-05 Thread Jesse Barnes
This lets us return to userspace more quickly and should improve init and suspend/resume times as well, allowing us to return to userspace sooner. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/in