Re: [Intel-gfx] [PATCH 12/21] drm/i915: Ensure eDP powered up during DP_SET_POWER operation in dp_prepare

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:44PM -0700, Keith Packard wrote: Any call to intel_dp_sink_dpms must ensure that the panel has power so that the DP_SET_POWER operation will be correctly received. The only one missing this was in intel_dp_prepare. Signed-off-by: Keith Packard kei...@keithp.com

Re: [Intel-gfx] [PATCH 12/21] drm/i915: Ensure eDP powered up during DP_SET_POWER operation in dp_prepare

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 19:45:02 +0200, Daniel Vetter dan...@ffwll.ch wrote: If I understand things correctly we don't need the vdd_on/off on dpms off because the panel is running and has power. Yes, that's correct; the aux channel works with either full power or with the force VDD bit turned on.

[Intel-gfx] [PATCH 12/21] drm/i915: Ensure eDP powered up during DP_SET_POWER operation in dp_prepare

2011-09-29 Thread Keith Packard
Any call to intel_dp_sink_dpms must ensure that the panel has power so that the DP_SET_POWER operation will be correctly received. The only one missing this was in intel_dp_prepare. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c |2 ++ 1 files changed, 2