Re: [Intel-gfx] [PATCH 12/26] drm/i915: Page table helpers, and define renames

2014-03-18 Thread Chris Wilson
On Mon, Mar 17, 2014 at 10:48:44PM -0700, Ben Widawsky wrote: --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h @@ -1,8 +1,11 @@ #ifndef _I915_GEM_GTT_H #define _I915_GEM_GTT_H -#define GEN6_PPGTT_PD_ENTRIES 512 -#define I915_PPGTT_PT_ENTRIES

Re: [Intel-gfx] [PATCH 12/26] drm/i915: Page table helpers, and define renames

2014-03-18 Thread Jesse Barnes
On Tue, 18 Mar 2014 09:05:58 + Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, Mar 17, 2014 at 10:48:44PM -0700, Ben Widawsky wrote: --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h @@ -1,8 +1,11 @@ #ifndef _I915_GEM_GTT_H #define

Re: [Intel-gfx] [PATCH 12/26] drm/i915: Page table helpers, and define renames

2014-03-18 Thread Ben Widawsky
On Tue, Mar 18, 2014 at 11:29:58AM -0700, Jesse Barnes wrote: On Tue, 18 Mar 2014 09:05:58 + Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, Mar 17, 2014 at 10:48:44PM -0700, Ben Widawsky wrote: --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++

[Intel-gfx] [PATCH 12/26] drm/i915: Page table helpers, and define renames

2014-03-17 Thread Ben Widawsky
These page table helpers make the code much cleaner. There is some room to use the arch/x86 header files. The reason I've opted not to is in several cases, the definitions are dictated by the CONFIG_ options which do not always indicate the restrictions in the GPU. While here, clean up the defines