Re: [Intel-gfx] [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption

2017-10-20 Thread Daniele Ceraolo Spurio
On 20/10/17 10:22, Chris Wilson wrote: Quoting Chris Wilson (2017-10-19 20:44:41) Quoting Michał Winiarski (2017-10-19 19:36:18) With GuC, we're scheduling tasklet on USER_INTERRUPT - since some work has completed, perhaps we're able to submit some more work. We're doing similar thing for

Re: [Intel-gfx] [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption

2017-10-20 Thread Chris Wilson
Quoting Chris Wilson (2017-10-19 20:44:41) > Quoting Michał Winiarski (2017-10-19 19:36:18) > > With GuC, we're scheduling tasklet on USER_INTERRUPT - since some work > > has completed, perhaps we're able to submit some more work. We're doing > > similar thing for preemption - after preemption has

Re: [Intel-gfx] [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption

2017-10-20 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-19 19:36:18) > +#define GUC_LOST_IRQ_WORK_DELAY_MS 100 > +static void guc_lost_user_interrupt(struct work_struct *work) > +{ > + struct guc_preempt_work *preempt_work = > + container_of(to_delayed_work(work), typeof(*preempt_work), > +

Re: [Intel-gfx] [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption

2017-10-19 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-19 19:36:18) > With GuC, we're scheduling tasklet on USER_INTERRUPT - since some work > has completed, perhaps we're able to submit some more work. We're doing > similar thing for preemption - after preemption has completed, it's time > to schedule the tasklet and

[Intel-gfx] [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption

2017-10-19 Thread Michał Winiarski
With GuC, we're scheduling tasklet on USER_INTERRUPT - since some work has completed, perhaps we're able to submit some more work. We're doing similar thing for preemption - after preemption has completed, it's time to schedule the tasklet and submit more work (since the engine is now idle).