Re: [Intel-gfx] [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing

2016-06-06 Thread Mika Kuoppala
Matthew Auld writes: > [ text/plain ] >> + /* WaDisableDynamicCreditSharing:kbl */ >> + if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0)) >> + WA_SET_BIT(GAMT_CHKN_BIT_REG, (1 << 28)); >> + > Let's play name that bit! > > Otherwise the patch

Re: [Intel-gfx] [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing

2016-06-03 Thread Matthew Auld
> + /* WaDisableDynamicCreditSharing:kbl */ > + if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0)) > + WA_SET_BIT(GAMT_CHKN_BIT_REG, (1 << 28)); > + Let's play name that bit! Otherwise the patch looks good, although slightly worrying that the hsd's state the WA is needed up to

[Intel-gfx] [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing

2016-05-27 Thread Mika Kuoppala
Bspec states that we need to turn off dynamic credit sharing on kbl revid a0 and b0. This happens by writing bit 28 on 0x4ab8. References: HSD#2225601, HSD#2226938, HSD#2225763 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_reg.h | 2 ++