Re: [Intel-gfx] [PATCH 13/44] drm/v3d: Delete v3d_dev->dev

2020-04-03 Thread Eric Anholt
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote: > > We already have it in v3d_dev->drm.dev with zero additional pointer > chasing. Personally I don't like duplicated pointers like this > because: > - reviewers need to check whether the pointer is for the same or > different objects if

[Intel-gfx] [PATCH 13/44] drm/v3d: Delete v3d_dev->dev

2020-04-03 Thread Daniel Vetter
We already have it in v3d_dev->drm.dev with zero additional pointer chasing. Personally I don't like duplicated pointers like this because: - reviewers need to check whether the pointer is for the same or different objects if there's multiple - compilers have an easier time too But also a bit a