Re: [Intel-gfx] [PATCH 2/2] drm/i915: Drop pointless WARN_ON

2019-06-07 Thread Ville Syrjälä
On Tue, Jun 04, 2019 at 12:36:46PM -0700, Manasi Navare wrote: > On Tue, Jun 04, 2019 at 05:02:14PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > intel_dp_link_down() is static and it's only called from the pre-ddi > > DP functions, so having a WARN_ON(HAS_DDI) in there is quite

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Drop pointless WARN_ON

2019-06-04 Thread Manasi Navare
On Tue, Jun 04, 2019 at 05:02:14PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_dp_link_down() is static and it's only called from the pre-ddi > DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless. > Remove it. > > Signed-off-by: Ville Syrjälä Looks good to

[Intel-gfx] [PATCH 2/2] drm/i915: Drop pointless WARN_ON

2019-06-04 Thread Ville Syrjala
From: Ville Syrjälä intel_dp_link_down() is static and it's only called from the pre-ddi DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless. Remove it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 3 --- 1 file changed, 3 deletions(-) diff --git