Re: [Intel-gfx] [PATCH 2/2] drm/i915: Require FEC for DSC on DP-MST

2023-09-20 Thread Ville Syrjälä
On Wed, Sep 20, 2023 at 12:20:51PM +0300, Jani Nikula wrote: > On Wed, 13 Sep 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The current check just asserts that we need FEC to use DSC > > with (non-eDP) DP-SST. But MST also needs FEC for DSC. Just > > check for !eDP instead to cover

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Require FEC for DSC on DP-MST

2023-09-20 Thread Jani Nikula
On Wed, 13 Sep 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The current check just asserts that we need FEC to use DSC > with (non-eDP) DP-SST. But MST also needs FEC for DSC. Just > check for !eDP instead to cover all the cases correctly. 128b/132b won't have crtc->fec_enable set, as

[Intel-gfx] [PATCH 2/2] drm/i915: Require FEC for DSC on DP-MST

2023-09-13 Thread Ville Syrjala
From: Ville Syrjälä The current check just asserts that we need FEC to use DSC with (non-eDP) DP-SST. But MST also needs FEC for DSC. Just check for !eDP instead to cover all the cases correctly. Cc: Luca Coelho Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +-