Re: [Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-11 Thread Govindapillai, Vinod
Thanks! Reviewed-by: Vinod Govindapillai > -Original Message- > From: Lisovskiy, Stanislav > Sent: 11 April 2022 11:14 > To: intel-gfx@lists.freedesktop.org > Cc: Lisovskiy, Stanislav ; Govindapillai, Vinod > ; Saarinen, Jani > Subject: [PATCH 2/2] drm/i915: Swap ret and status

[Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-11 Thread Stanislav Lisovskiy
If ret isn't zero, it is almost for sure ETIMEDOUT, because we use it in wait_for macro which does continuous retries until timeout is reached. If we still ran out of time and retries, we most likely would be interested in getting status, to understand what was the actual error propagated from

[Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-11 Thread Stanislav Lisovskiy
If ret isn't zero, it is almost for sure ETIMEDOUT, because we use it in wait_for macro which does continuous retries until timeout is reached. If we still ran out of time and retries, we most likely would be interested in getting status, to understand what was the actual error propagated from

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-08 Thread Govindapillai, Vinod
On Fri, 2022-04-08 at 15:52 +0300, Stanislav Lisovskiy wrote: > If ret isn't zero, it is almost for sure ETIMEDOUT, because > we use it in wait_for macro which does continuous retries > until timeout is reached. If we still ran out of time and > retries, we most likely would be interested in

[Intel-gfx] [PATCH 2/2] drm/i915: Swap ret and status returned from skl_pcode_request

2022-04-08 Thread Stanislav Lisovskiy
If ret isn't zero, it is almost for sure ETIMEDOUT, because we use it in wait_for macro which does continuous retries until timeout is reached. If we still ran out of time and retries, we most likely would be interested in getting status, to understand what was the actual error propagated from