[Intel-gfx] [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap

2012-01-24 Thread Ben Widawsky
After the ILK vt-d workaround patches it became clear that we had introduced a bug. Chris Wilson tracked down the issue to recursive calls to unmap. This happens because we try to optimize waiting on requests by calling retire requests after the wait, which may drop the last reference on an

Re: [Intel-gfx] [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap

2012-01-24 Thread Keith Packard
On Tue, 24 Jan 2012 14:42:03 -0800, Ben Widawsky b...@bwidawsk.net wrote: This patch fixes gem_unref_active_buffers from i-g-t in the non-VTd case (ie. do_idle_maps forced to true). Nice, one-line fix. (if you agree with my bikeshed in the previous patch, this will have to be changed to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap

2012-01-24 Thread Ben Widawsky
On 01/24/12 15:00, Keith Packard wrote: On Tue, 24 Jan 2012 14:42:03 -0800, Ben Widawskyb...@bwidawsk.net wrote: This patch fixes gem_unref_active_buffers from i-g-t in the non-VTd case (ie. do_idle_maps forced to true). Nice, one-line fix. (if you agree with mybikeshed in the previous

[Intel-gfx] [PATCH 2/2] drm/i915: drm/i915: Fix recursive calls to unmap

2012-01-24 Thread Ben Widawsky
After the ILK vt-d workaround patches it became clear that we had introduced a bug. Chris Wilson tracked down the issue to recursive calls to unmap. This happens because we try to optimize waiting on requests by calling retire requests after the wait, which may drop the last reference on an