Re: [Intel-gfx] [PATCH 2/2] drm/i915: only assign dev_priv->pch_id on successful pch detection

2018-01-27 Thread Jani Nikula
On Fri, 26 Jan 2018, Chris Wilson wrote: > Quoting David Weinehall (2018-01-26 15:53:53) >> On Fri, Jan 26, 2018 at 04:48:05PM +0200, Jani Nikula wrote: >> > Currently pch_id gets assigned also when there's no pch. It doesn't look >> > like it makes a difference, but do the right thing anyway. >>

Re: [Intel-gfx] [PATCH 2/2] drm/i915: only assign dev_priv->pch_id on successful pch detection

2018-01-26 Thread Chris Wilson
Quoting David Weinehall (2018-01-26 15:53:53) > On Fri, Jan 26, 2018 at 04:48:05PM +0200, Jani Nikula wrote: > > Currently pch_id gets assigned also when there's no pch. It doesn't look > > like it makes a difference, but do the right thing anyway. > > Makes sense. > > Reviewed-by: David Weinehal

Re: [Intel-gfx] [PATCH 2/2] drm/i915: only assign dev_priv->pch_id on successful pch detection

2018-01-26 Thread David Weinehall
On Fri, Jan 26, 2018 at 04:48:05PM +0200, Jani Nikula wrote: > Currently pch_id gets assigned also when there's no pch. It doesn't look > like it makes a difference, but do the right thing anyway. Makes sense. Reviewed-by: David Weinehall > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i

[Intel-gfx] [PATCH 2/2] drm/i915: only assign dev_priv->pch_id on successful pch detection

2018-01-26 Thread Jani Nikula
Currently pch_id gets assigned also when there's no pch. It doesn't look like it makes a difference, but do the right thing anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv