Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Damien Lespiau
On Wed, Jul 09, 2014 at 04:23:50PM +0200, Daniel Vetter wrote: > For me the only trouble with this disdinction is that people consistently > place tests in the wrong Makefile target. Hence I'd like to see those two > Makefile targets being unified (which requires adjustements in piglit, > too) to v

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 01:23:46PM +, Gore, Tim wrote: > Some comments on Daniels' comments inline > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Not sure whether forcing the reuse of igt_subtest_init makes a lot of sense > > si

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-09 Thread Gore, Tim
gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init > for simple tests > > On Fri, Jun 27, 2014 at 03:15:37PM +0100, tim.g...@intel.com wrote: > > From: Tim Gore > > > > igt_subtest_init mainly does stuff that we also want for simple/single > > tests,

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-07 Thread Daniel Vetter
On Fri, Jun 27, 2014 at 03:15:37PM +0100, tim.g...@intel.com wrote: > From: Tim Gore > > igt_subtest_init mainly does stuff that we also want for > simple/single tests, such as looking for --list-subtests > and --help options and calling common_init. So just call > this from igt_simple_init and t

Re: [Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-07-01 Thread Thomas Wood
On 27 June 2014 15:15, wrote: > From: Tim Gore > > igt_subtest_init mainly does stuff that we also want for > simple/single tests, such as looking for --list-subtests > and --help options and calling common_init. So just call > this from igt_simple_init and then set tests_with_subtests > to fals

[Intel-gfx] [PATCH 2/2] intel-gpu-tools: Re-use igt_subtest_init for simple tests

2014-06-27 Thread tim . gore
From: Tim Gore igt_subtest_init mainly does stuff that we also want for simple/single tests, such as looking for --list-subtests and --help options and calling common_init. So just call this from igt_simple_init and then set tests_with_subtests to false. NOTE that this means that check_igt_exit i