Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-22 Thread Matthew Auld
On Tue, 21 Jun 2022 at 19:38, Juha-Pekka Heikkila wrote: > > On 21.6.2022 13.53, Matthew Auld wrote: > > On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila > > wrote: > >> > >> On 10.6.2022 20.43, Matthew Auld wrote: > >>> On Fri, 10 Jun 2022 at 15:53, Matthew Auld > >>> wrote: > > On

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-21 Thread Juha-Pekka Heikkila
On 21.6.2022 13.53, Matthew Auld wrote: On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: On 10.6.2022 20.43, Matthew Auld wrote: On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: From: CQ Tang Display might allocate a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-21 Thread Matthew Auld
On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: > > On 10.6.2022 20.43, Matthew Auld wrote: > > On Fri, 10 Jun 2022 at 15:53, Matthew Auld > > wrote: > >> > >> On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila > >> wrote: > >>> > >>> From: CQ Tang > >>> > >>> Display might allocate a

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-20 Thread Juha-Pekka Heikkila
On 10.6.2022 20.43, Matthew Auld wrote: On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: From: CQ Tang Display might allocate a smem object and call i915_vma_pin_iomap(), the existing code will fail. This fix was suggested by

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: > > On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila > wrote: > > > > From: CQ Tang > > > > Display might allocate a smem object and call > > i915_vma_pin_iomap(), the existing code will fail. > > > > This fix was suggested by Chris P Wilson,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Matthew Auld
On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: > > From: CQ Tang > > Display might allocate a smem object and call > i915_vma_pin_iomap(), the existing code will fail. > > This fix was suggested by Chris P Wilson, that we pin > the smem with i915_gem_object_pin_map_unlocked(). > > v2

[Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-10 Thread Juha-Pekka Heikkila
From: CQ Tang Display might allocate a smem object and call i915_vma_pin_iomap(), the existing code will fail. This fix was suggested by Chris P Wilson, that we pin the smem with i915_gem_object_pin_map_unlocked(). v2 (jheikkil): Change i915_gem_object_pin_map_unlocked to