Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 14:52, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:46:10) On 02/10/2018 14:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:13:14) On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 14:46:10) > > On 02/10/2018 14:22, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-02 14:13:14) > >> > >> On 02/10/2018 13:24, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > > On 01/10/2018 20:44, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 14:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:13:14) On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 14:13:14) > > On 02/10/2018 13:24, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > >> > >> On 01/10/2018 20:44, Chris Wilson wrote: > >>> The final call to zlib_deflate(Z_FINISH) may require more output > >>> space to be allocated and so

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > > On 01/10/2018 20:44, Chris Wilson wrote: > > The final call to zlib_deflate(Z_FINISH) may require more output > > space to be allocated and so needs to re-invoked. Failure to do so in > > the current code leads to incomplete zlib streams (albeit

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to incomplete zlib streams (albeit intact due to the use of Z_SYNC_FLUSH) resulting in the

[Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-01 Thread Chris Wilson
The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to incomplete zlib streams (albeit intact due to the use of Z_SYNC_FLUSH) resulting in the occasional short object capture. Testcase: