Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point

2020-04-20 Thread Ville Syrjälä
On Mon, Apr 20, 2020 at 05:45:01PM +0300, Jani Nikula wrote: > On Fri, 17 Apr 2020, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > No reason that I can see why we should enable TRANS_DDI_FUNC_CTL > > before we set up the watermarks of confogiure the mbus stuff. > > In fact reordering these

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point

2020-04-20 Thread Jani Nikula
On Fri, 17 Apr 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > No reason that I can see why we should enable TRANS_DDI_FUNC_CTL > before we set up the watermarks of confogiure the mbus stuff. > In fact reordering these seems to match the bspec sequence better, > and cricually will allow us

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point

2020-04-17 Thread Chris Wilson
Quoting Ville Syrjala (2020-04-17 14:47:18) > From: Ville Syrjälä > > No reason that I can see why we should enable TRANS_DDI_FUNC_CTL > before we set up the watermarks of confogiure the mbus stuff. > In fact reordering these seems to match the bspec sequence better, > and cricually will allow

[Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point

2020-04-17 Thread Ville Syrjala
From: Ville Syrjälä No reason that I can see why we should enable TRANS_DDI_FUNC_CTL before we set up the watermarks of confogiure the mbus stuff. In fact reordering these seems to match the bspec sequence better, and cricually will allow us to push the TRANS_DDI_FUNC_CTL enable into the encoder