Re: [Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-17 Thread Jani Nikula
On Wed, 17 Aug 2022, Lucas De Marchi wrote: > On Wed, Aug 17, 2022 at 10:00:01AM +0300, Jani Nikula wrote: >>On Tue, 16 Aug 2022, Lucas De Marchi wrote: >>> On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote: -#define _MIPIA_DEVICE_READY(dev_priv->mipi_mmio_base +

Re: [Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-17 Thread Lucas De Marchi
On Wed, Aug 17, 2022 at 10:00:01AM +0300, Jani Nikula wrote: On Tue, 16 Aug 2022, Lucas De Marchi wrote: On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Prefer adding anonymous sub-structs even for single

Re: [Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-17 Thread Jani Nikula
On Tue, 16 Aug 2022, Lucas De Marchi wrote: > On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote: >>Move display related members under drm_i915_private display sub-struct. >> >>Prefer adding anonymous sub-structs even for single members that aren't >>our own structs. >> >>Abstract mmio

Re: [Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-16 Thread Lucas De Marchi
On Thu, Aug 11, 2022 at 06:07:35PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Prefer adding anonymous sub-structs even for single members that aren't our own structs. Abstract mmio base member access in register definitions in a macro.

[Intel-gfx] [PATCH 24/39] drm/i915: move mipi_mmio_base to display.dsi

2022-08-11 Thread Jani Nikula
Move display related members under drm_i915_private display sub-struct. Prefer adding anonymous sub-structs even for single members that aren't our own structs. Abstract mmio base member access in register definitions in a macro. Signed-off-by: Jani Nikula ---