Re: [Intel-gfx] [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind

2020-06-03 Thread Daniel Vetter
On Tue, Jun 02, 2020 at 02:00:16PM +0100, Liviu Dudau wrote: > On Tue, Jun 02, 2020 at 11:51:40AM +0200, Daniel Vetter wrote: > > This is already taken care of by drm_atomic_helper_shutdown(), and > > in that case only for the CRTC which are actually on. > > > > Only tricky bit here is that we

Re: [Intel-gfx] [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind

2020-06-02 Thread Liviu Dudau
On Tue, Jun 02, 2020 at 11:51:40AM +0200, Daniel Vetter wrote: > This is already taken care of by drm_atomic_helper_shutdown(), and > in that case only for the CRTC which are actually on. > > Only tricky bit here is that we kill the interrupt handling before we > shut down crtc, so need to

[Intel-gfx] [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind

2020-06-02 Thread Daniel Vetter
This is already taken care of by drm_atomic_helper_shutdown(), and in that case only for the CRTC which are actually on. Only tricky bit here is that we kill the interrupt handling before we shut down crtc, so need to reorder that. Signed-off-by: Daniel Vetter Cc: Liviu Dudau Cc: Brian Starkey