Re: [Intel-gfx] [PATCH 3/3] drm/i915/execlists: Apply a full mb before execution for Braswell

2018-12-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-12-06 13:12:35) > > On 06/12/2018 08:44, Chris Wilson wrote: > > Braswell is really picky about having our writes posted to memory before > > we execute or else the GPU may see stale values. A wmb() is insufficient > > as it only ensures the writes are visible to

Re: [Intel-gfx] [PATCH 3/3] drm/i915/execlists: Apply a full mb before execution for Braswell

2018-12-06 Thread Tvrtko Ursulin
On 06/12/2018 08:44, Chris Wilson wrote: Braswell is really picky about having our writes posted to memory before we execute or else the GPU may see stale values. A wmb() is insufficient as it only ensures the writes are visible to other cores, we need a full mb() to ensure the writes are in

[Intel-gfx] [PATCH 3/3] drm/i915/execlists: Apply a full mb before execution for Braswell

2018-12-06 Thread Chris Wilson
Braswell is really picky about having our writes posted to memory before we execute or else the GPU may see stale values. A wmb() is insufficient as it only ensures the writes are visible to other cores, we need a full mb() to ensure the writes are in memory and visible to the GPU. The most