Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Remove last submission result from debugfs

2017-05-19 Thread Michal Wajdeczko
On Fri, May 19, 2017 at 11:38:29AM +0300, Joonas Lahtinen wrote: > On to, 2017-05-18 at 11:31 +, Michal Wajdeczko wrote: > > Debugfs does not seems to be a right place to display transient data. > > If we want to capture errors, we should log them. > > > > Signed-off-by: Michal Wajdeczko > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Remove last submission result from debugfs

2017-05-19 Thread Joonas Lahtinen
On to, 2017-05-18 at 11:31 +, Michal Wajdeczko wrote: > Debugfs does not seems to be a right place to display transient data. > If we want to capture errors, we should log them. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Tvrtko Ursulin > @@ -2482,7 +2482,6 @@ static voi

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Remove last submission result from debugfs

2017-05-19 Thread Chris Wilson
On Thu, May 18, 2017 at 11:31:04AM +, Michal Wajdeczko wrote: > Debugfs does not seems to be a right place to display transient data. > If we want to capture errors, we should log them. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Tvrtko Ursulin All 3 Reviewed-by: Chris Wil

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Remove last submission result from debugfs

2017-05-18 Thread Michal Wajdeczko
Debugfs does not seems to be a right place to display transient data. If we want to capture errors, we should log them. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c| 1 - drivers/gpu/drm/i915/i915_guc_submission.c | 1 - dr