Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Hans de Goede
Hi, On 16-12-2019 15:14, Ville Syrjälä wrote: On Mon, Dec 16, 2019 at 02:51:54PM +0100, Hans de Goede wrote: Hi, Thank you for the reviews. On 16-12-2019 14:45, Ville Syrjälä wrote: On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote: When the LCD has not been turned on by the

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Ville Syrjälä
On Mon, Dec 16, 2019 at 02:51:54PM +0100, Hans de Goede wrote: > Hi, > > Thank you for the reviews. > > On 16-12-2019 14:45, Ville Syrjälä wrote: > > On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote: > >> When the LCD has not been turned on by the firmware/GOP, because e.g. the > >>

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Hans de Goede
Hi, Thank you for the reviews. On 16-12-2019 14:45, Ville Syrjälä wrote: On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote: When the LCD has not been turned on by the firmware/GOP, because e.g. the device was booted with an external monitor connected over HDMI, we should not turn

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Ville Syrjälä
On Sun, Dec 15, 2019 at 05:38:08PM +0100, Hans de Goede wrote: > When the LCD has not been turned on by the firmware/GOP, because e.g. the > device was booted with an external monitor connected over HDMI, we should > not turn on the panel-enable GPIO when we request it. > > Turning on the

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-16 Thread Linus Walleij
On Sun, Dec 15, 2019 at 5:38 PM Hans de Goede wrote: > When the LCD has not been turned on by the firmware/GOP, because e.g. the > device was booted with an external monitor connected over HDMI, we should > not turn on the panel-enable GPIO when we request it. > > Turning on the panel-enable

[Intel-gfx] [PATCH 3/5] drm/i915/dsi: Init panel-enable GPIO to low when the LCD is initially off

2019-12-15 Thread Hans de Goede
When the LCD has not been turned on by the firmware/GOP, because e.g. the device was booted with an external monitor connected over HDMI, we should not turn on the panel-enable GPIO when we request it. Turning on the panel-enable GPIO when we request it, means we turn it on too early in the