Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-16 Thread Daniele Ceraolo Spurio
+ +fail: + /* +* We've failed to load the firmware :( +* +* Decide whether to disable GuC submission and fall back to +* execlist mode, and whether to hide the error by returning +* zero or to return -EIO, which the caller will treat as a +

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-16 Thread Tvrtko Ursulin
On 15/12/2016 15:47, Arkadiusz Hiler wrote: Current version of intel_guc_load() does a lot: - cares about submission - loads huc Not yet, no? So instead you could say that you are preparing the groundworks to make adding in the HuC fit better. - implement WA This change offloads some

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-16 Thread Arkadiusz Hiler
On Thu, Dec 15, 2016 at 02:26:29PM -0800, Daniele Ceraolo Spurio wrote: > > > On 15/12/16 07:47, Arkadiusz Hiler wrote: > > Current version of intel_guc_load() does a lot: > > - cares about submission > > - loads huc > > - implement WA > > > > This change offloads some of the logic to

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-16 Thread Arkadiusz Hiler
On Thu, Dec 15, 2016 at 05:38:16PM +0100, Michal Wajdeczko wrote: > On Thu, Dec 15, 2016 at 04:47:06PM +0100, Arkadiusz Hiler wrote: > > Current version of intel_guc_load() does a lot: > > - cares about submission > > - loads huc > > - implement WA > > > > This change offloads some of the

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-15 Thread Daniele Ceraolo Spurio
On 15/12/16 07:47, Arkadiusz Hiler wrote: Current version of intel_guc_load() does a lot: - cares about submission - loads huc - implement WA This change offloads some of the logic to intel_uc_load(), which now cares about the above. Cc: Anusha Srivatsa Cc:

Re: [Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-15 Thread Michal Wajdeczko
On Thu, Dec 15, 2016 at 04:47:06PM +0100, Arkadiusz Hiler wrote: > Current version of intel_guc_load() does a lot: > - cares about submission > - loads huc > - implement WA > > This change offloads some of the logic to intel_uc_load(), which now > cares about the above. > > Cc: Anusha

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load()

2016-12-15 Thread Arkadiusz Hiler
Current version of intel_guc_load() does a lot: - cares about submission - loads huc - implement WA This change offloads some of the logic to intel_uc_load(), which now cares about the above. Cc: Anusha Srivatsa Cc: Jeff McGee Cc: Michal