Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 14/07/16 15:26, Daniel Vetter wrote: On Thu, Jul 14, 2016 at 03:08:41PM +0100, Dave Gordon wrote: On 13/07/16 13:48, Daniel Vetter wrote: On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote: No, the

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Thu, 14 Jul 2016, Daniel Vetter wrote: On Wed, Jul 13, 2016 at 03:52:39PM +0100, Peter Antoine wrote: On Wed, 13 Jul 2016, Daniel Vetter wrote: On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote:

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 14/07/16 15:16, Daniel Vetter wrote: On Wed, Jul 13, 2016 at 03:52:39PM +0100, Peter Antoine wrote: On Wed, 13 Jul 2016, Daniel Vetter wrote: On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote: No,

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Thu, Jul 14, 2016 at 03:08:41PM +0100, Dave Gordon wrote: > On 13/07/16 13:48, Daniel Vetter wrote: > > On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: > > > On Thu, 23 Jun 2016, Dave Gordon wrote: > > > > On 22/06/16 09:31, Daniel Vetter wrote: > > > > No, the *correct* fix is

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Wed, Jul 13, 2016 at 03:52:39PM +0100, Peter Antoine wrote: > On Wed, 13 Jul 2016, Daniel Vetter wrote: > > > On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: > > > On Thu, 23 Jun 2016, Dave Gordon wrote: > > > > On 22/06/16 09:31, Daniel Vetter wrote: > > > > No, the *correct*

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 13/07/16 13:48, Daniel Vetter wrote: On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote: No, the *correct* fix is to unify all the firmware loaders we have. There should just be ONE piece of code that

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Wed, 13 Jul 2016, Daniel Vetter wrote: On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote: No, the *correct* fix is to unify all the firmware loaders we have. There should just be ONE piece of code

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote: > On Thu, 23 Jun 2016, Dave Gordon wrote: > > On 22/06/16 09:31, Daniel Vetter wrote: > > No, the *correct* fix is to unify all the firmware loaders we have. > > There should just be ONE piece of code that can be used to fetch and > >

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 29/06/16 18:59, Rodrigo Vivi wrote: On Wed, Jun 29, 2016 at 7:31 AM, Dave Gordon wrote: On 29/06/16 00:03, Rodrigo Vivi wrote: I don't believe we need to be that extreme here. Daniel asked a cleaner version, but we don't need to block the huc on a full rework of

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

But the merge on hug/guc loading is just the minor thing Daniel asked. The major request is to stop using the fetch_status, but errnos instead. so, maybe one extra patch that simplifies this right now before this series would be the ideal so we could speed up the merge and maybe later to the

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 29/06/16 00:03, Rodrigo Vivi wrote: I don't believe we need to be that extreme here. Daniel asked a cleaner version, but we don't need to block the huc on a full rework of an unified fw loader. Oh, I agree, we should take this "mostly" as-is and then reunify them after. .Dave.

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

I don't believe we need to be that extreme here. Daniel asked a cleaner version, but we don't need to block the huc on a full rework of an unified fw loader. On Tue, Jun 28, 2016 at 8:45 AM, Dave Gordon wrote: > On 28/06/16 15:54, Dave Gordon wrote: >> >> On 21/06/16

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 28/06/16 15:54, Dave Gordon wrote: On 21/06/16 19:11, Peter Antoine wrote: From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 21/06/16 19:11, Peter Antoine wrote: From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. Signed-off-by: Alex

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Thu, 23 Jun 2016, Dave Gordon wrote: On 22/06/16 09:31, Daniel Vetter wrote: On Tue, Jun 21, 2016 at 07:11:22PM +0100, Peter Antoine wrote: From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On 22/06/16 09:31, Daniel Vetter wrote: On Tue, Jun 21, 2016 at 07:11:22PM +0100, Peter Antoine wrote: From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

On Tue, Jun 21, 2016 at 07:11:22PM +0100, Peter Antoine wrote: > From: Alex Dai > > The HuC loading process is similar to GuC. The intel_uc_fw_fetch() > is used for both cases. > > HuC loading needs to be before GuC loading. The WOPCM setting must > be done early before

[Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. Signed-off-by: Alex Dai Signed-off-by: