Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 03:00:20PM +, Tvrtko Ursulin wrote: > > On 12/01/2017 11:33, Chris Wilson wrote: > >On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: > >>In preparation for the next patch to convert to using an anonymous union > >>and leaving the excess bytes in the union

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 11:33, Chris Wilson wrote: On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: > In preparation for the next patch to convert to using an anonymous union > and leaving the excess bytes in the union uninitialised, we first need > to make sure we do not compare using those uninitialised bytes. We also > want to

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 10:05, Chris Wilson wrote: On Thu, Jan 12, 2017 at 07:14:55AM +, Tvrtko Ursulin wrote: On 12/01/2017 07:08, Tvrtko Ursulin wrote: On 11/01/2017 21:51, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 07:14:55AM +, Tvrtko Ursulin wrote: > > On 12/01/2017 07:08, Tvrtko Ursulin wrote: > > > >On 11/01/2017 21:51, Chris Wilson wrote: > >>In preparation for the next patch to convert to using an anonymous union > >>and leaving the excess bytes in the union uninitialised,

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-11 Thread Tvrtko Ursulin
On 12/01/2017 07:08, Tvrtko Ursulin wrote: On 11/01/2017 21:51, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those uninitialised bytes.

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-11 Thread Tvrtko Ursulin
On 11/01/2017 21:51, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those uninitialised bytes. We also want to preserve the compactness of

[Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-11 Thread Chris Wilson
In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those uninitialised bytes. We also want to preserve the compactness of the code, avoiding a second call to memcmp or