Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-09-02 Thread Daniel Vetter
On Thu, Aug 27, 2015 at 10:49:28AM +0800, Zhiyuan Lv wrote: > Hi Daniel, > > On Wed, Aug 26, 2015 at 10:50:23AM +0200, Daniel Vetter wrote: > > > > @@ -332,6 +332,12 @@ int i915_gem_context_init(struct drm_device > > > > *dev) > > > > if (WARN_ON(dev_priv->ring[RCS].default_context)) > >

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-26 Thread Daniel Vetter
On Mon, Aug 24, 2015 at 03:36:46PM +0300, Joonas Lahtinen wrote: On pe, 2015-08-21 at 10:24 +0800, Zhiyuan Lv wrote: Hi Joonas, Thanks for the review! And my reply inline. Regards, -Zhiyuan On Thu, Aug 20, 2015 at 02:23:11PM +0300, Joonas Lahtinen wrote: Hi, On to,

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-26 Thread Zhiyuan Lv
Hi Daniel, On Wed, Aug 26, 2015 at 10:50:23AM +0200, Daniel Vetter wrote: @@ -332,6 +332,12 @@ int i915_gem_context_init(struct drm_device *dev) if (WARN_ON(dev_priv-ring[RCS].default_context)) return 0; + if (intel_vgpu_active(dev)) { +

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-24 Thread Joonas Lahtinen
On pe, 2015-08-21 at 10:24 +0800, Zhiyuan Lv wrote: Hi Joonas, Thanks for the review! And my reply inline. Regards, -Zhiyuan On Thu, Aug 20, 2015 at 02:23:11PM +0300, Joonas Lahtinen wrote: Hi, On to, 2015-08-20 at 17:40 +0800, Zhiyuan Lv wrote: On Thu, Aug 20, 2015 at

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Chris Wilson
On Thu, Aug 20, 2015 at 03:45:20PM +0800, Zhiyuan Lv wrote: Broadwell hardware supports both ring buffer mode and execlist mode. When i915 runs inside a VM with Intel GVT-g, we allow execlist mode only. The reason is that GVT-g does not support the dynamic mode switch between ring buffer mode

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Chris Wilson
On Thu, Aug 20, 2015 at 04:55:08PM +0800, Zhiyuan Lv wrote: Hi Chris, On Thu, Aug 20, 2015 at 09:34:05AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at 03:45:20PM +0800, Zhiyuan Lv wrote: Broadwell hardware supports both ring buffer mode and execlist mode. When i915 runs inside a

[Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Zhiyuan Lv
Broadwell hardware supports both ring buffer mode and execlist mode. When i915 runs inside a VM with Intel GVT-g, we allow execlist mode only. The reason is that GVT-g does not support the dynamic mode switch between ring buffer mode and execlist mode when running multiple virtual machines.

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Zhiyuan Lv
On Thu, Aug 20, 2015 at 10:22:37AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at 04:55:08PM +0800, Zhiyuan Lv wrote: Hi Chris, On Thu, Aug 20, 2015 at 09:34:05AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at 03:45:20PM +0800, Zhiyuan Lv wrote: Broadwell hardware supports

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Zhiyuan Lv
Hi Chris, On Thu, Aug 20, 2015 at 09:34:05AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at 03:45:20PM +0800, Zhiyuan Lv wrote: Broadwell hardware supports both ring buffer mode and execlist mode. When i915 runs inside a VM with Intel GVT-g, we allow execlist mode only. The reason is

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Joonas Lahtinen
Hi, On to, 2015-08-20 at 17:40 +0800, Zhiyuan Lv wrote: On Thu, Aug 20, 2015 at 10:22:37AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at 04:55:08PM +0800, Zhiyuan Lv wrote: Hi Chris, On Thu, Aug 20, 2015 at 09:34:05AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-20 Thread Zhiyuan Lv
Hi Joonas, Thanks for the review! And my reply inline. Regards, -Zhiyuan On Thu, Aug 20, 2015 at 02:23:11PM +0300, Joonas Lahtinen wrote: Hi, On to, 2015-08-20 at 17:40 +0800, Zhiyuan Lv wrote: On Thu, Aug 20, 2015 at 10:22:37AM +0100, Chris Wilson wrote: On Thu, Aug 20, 2015 at

[Intel-gfx] [PATCH 3/7] drm/i915: Always enable execlists on BDW for vgpu

2015-08-19 Thread Zhiyuan Lv
Broadwell hardware supports both ring buffer mode and execlist mode. When i915 runs inside a VM with Intel GVT-g, we allow execlist mode only. The reason is that GVT-g does not support the dynamic mode switch between ring buffer mode and execlist mode when running multiple virtual machines.