Re: [Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-08 Thread Thomas Gleixner
On Thu, 7 Dec 2017, Matthew Auld wrote: > Makes things a little easier to follow. I disagree. The comment explains gms (what ever that is) in ascending order and the code has that implemented the same way. Now you change the code to descending order. How is that easier to follow? Not at all.

[Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-07 Thread Matthew Auld
Makes things a little easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson

Re: [Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Ville Syrjälä
On Tue, Dec 05, 2017 at 09:02:43PM +, Matthew Auld wrote: > Makes things a little easier to follow. > > Suggested-by: Ville Syrjälä > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Ville

[Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-05 Thread Matthew Auld
Makes things a little easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson

[Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-11-24 Thread Matthew Auld
Makes things much easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson