Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Daniel Vetter
On Tue, May 12, 2015 at 06:01:40PM +0100, Daniel Stone wrote: > Hi, > > On 12 May 2015 at 17:57, Daniel Vetter wrote: > > On Tue, May 12, 2015 at 04:07:14PM +0200, Maarten Lankhorst wrote: > >> Op 12-05-15 om 12:03 schreef Daniel Vetter: > >> > On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst >

Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Daniel Stone
Hi, On 12 May 2015 at 17:57, Daniel Vetter wrote: > On Tue, May 12, 2015 at 04:07:14PM +0200, Maarten Lankhorst wrote: >> Op 12-05-15 om 12:03 schreef Daniel Vetter: >> > On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst >> > wrote: >> >> @@ -11953,16 +11930,14 @@ check_shared_dpll_state(struct

Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Daniel Vetter
On Tue, May 12, 2015 at 04:07:14PM +0200, Maarten Lankhorst wrote: > Op 12-05-15 om 12:03 schreef Daniel Vetter: > > On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst > > wrote: > >> @@ -11953,16 +11930,14 @@ check_shared_dpll_state(struct drm_device *dev) > >> > >> for_each_intel

Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Maarten Lankhorst
Op 12-05-15 om 12:03 schreef Daniel Vetter: > On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst > wrote: >> @@ -11953,16 +11930,14 @@ check_shared_dpll_state(struct drm_device *dev) >> >> for_each_intel_crtc(dev, crtc) { >> if (crtc->base.state->active &&

Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Daniel Vetter
On Mon, May 11, 2015 at 4:25 PM, Maarten Lankhorst wrote: > @@ -11953,16 +11930,14 @@ check_shared_dpll_state(struct drm_device *dev) > > for_each_intel_crtc(dev, crtc) { > if (crtc->base.state->active && > intel_crtc_to_shared_dpll(crtc) == pll) > -

Re: [Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-12 Thread Daniel Vetter
On Mon, May 11, 2015 at 04:25:09PM +0200, Maarten Lankhorst wrote: > Small behavioral change: DPLL_DVO_2X_MODE may stay enabled during modeset > for I830 if new state requires it, instead of being disabled and enabled > again. Imo this should be split in the remaing changes to get rid of ->active

[Intel-gfx] [PATCH 33/42] drm/i915: remove crtc->active tracking completely

2015-05-11 Thread Maarten Lankhorst
Small behavioral change: DPLL_DVO_2X_MODE may stay enabled during modeset for I830 if new state requires it, instead of being disabled and enabled again. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 140 ++- drivers/gpu/drm/i915/inte