Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-22 Thread Kumar, Shobhit
On 5/21/2014 2:25 AM, Damien Lespiau wrote: On Tue, May 20, 2014 at 09:46:01PM +0530, Shobhit Kumar wrote: - UI is a period, so is homogeneous to time (s), but ui_num being in s^-1 and ui_den a constant, ui_num/ui_den looks like a frequency. Or could it be that UI = ui_den / ui_num? would

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-20 Thread Shobhit Kumar
On Monday 19 May 2014 07:53 PM, Damien Lespiau wrote: On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote: +#define NS_MHZ_RATIO 100 [...] +static bool generic_init(struct intel_dsi_device *dsi) +{ [...] + /* +* ui(s) = 1/f [f in hz] +* ui(ns) =

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-20 Thread Damien Lespiau
On Tue, May 20, 2014 at 09:46:01PM +0530, Shobhit Kumar wrote: - UI is a period, so is homogeneous to time (s), but ui_num being in s^-1 and ui_den a constant, ui_num/ui_den looks like a frequency. Or could it be that UI = ui_den / ui_num? would be confusing, but the code below would

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-19 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote: +#define NS_MHZ_RATIO 100 [...] +static bool generic_init(struct intel_dsi_device *dsi) +{ [...] + /* + * ui(s) = 1/f [f in hz] + * ui(ns) = 10^9/f*10^6 [f in Mhz] - 10^3/f(Mhz) ui(ns) = 10^9/(f*10^6) +

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-16 Thread Shobhit Kumar
Thanks Damien for your review On Thursday 15 May 2014 10:18 PM, Damien Lespiau wrote: On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote: This driver makes use of the generic panel information from the VBT. Panel information is classified into two - panel configuration and panel

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-16 Thread Damien Lespiau
On Thu, May 15, 2014 at 05:48:57PM +0100, Damien Lespiau wrote: +static struct gpio_table gtable[] = { const Please, disregard this comment. It's being written to to track GPIO initialization. -- Damien ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-15 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote: This driver makes use of the generic panel information from the VBT. Panel information is classified into two - panel configuration and panel power sequence which is unique to each panel. The generic driver uses the panel

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-04-13 Thread Shobhit Kumar
This driver makes use of the generic panel information from the VBT. Panel information is classified into two - panel configuration and panel power sequence which is unique to each panel. The generic driver uses the panel configuration and sequence parsed from VBT block #52 and #53 v2: Address