Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-12 Thread Daniel Vetter
On Fri, Mar 09, 2018 at 12:54:43PM -0800, Eric Anholt wrote: > Ville Syrjala writes: > > > From: Ville Syrj??l?? > > > > Only create framebuffers with supported format/modifier combinations by > > checking that at least one plane

Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-12 Thread Ville Syrjälä
On Fri, Mar 09, 2018 at 12:54:43PM -0800, Eric Anholt wrote: > Ville Syrjala writes: > > > From: Ville Syrjälä > > > > Only create framebuffers with supported format/modifier combinations by > > checking that at least one plane

Re: [Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-09 Thread Eric Anholt
Ville Syrjala writes: > From: Ville Syrjälä > > Only create framebuffers with supported format/modifier combinations by > checking that at least one plane supports the requested combination. > > Using drm_any_plane_has_format() is

[Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-09 Thread Ville Syrjala
From: Ville Syrjälä Only create framebuffers with supported format/modifier combinations by checking that at least one plane supports the requested combination. Using drm_any_plane_has_format() is somewhat suboptimal for vc4 since the planes have (mostly) uniform