Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init

2016-12-27 Thread Arkadiusz Hiler
On Fri, Dec 23, 2016 at 01:19:18PM -0800, Daniele Ceraolo Spurio wrote: > > > On 15/12/16 07:47, Arkadiusz Hiler wrote: > > Let intel_guc_init() focus on determining and fetching the correct > > firmware. > > > > This patch introduces intel_sanitize_uc_params() that is called from > >

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init

2016-12-23 Thread Daniele Ceraolo Spurio
On 15/12/16 07:47, Arkadiusz Hiler wrote: Let intel_guc_init() focus on determining and fetching the correct firmware. This patch introduces intel_sanitize_uc_params() that is called from intel_uc_init(). Then, if we have GuC, we can call intel_guc_init() conditionally and we do not have to

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init

2016-12-15 Thread Arkadiusz Hiler
Let intel_guc_init() focus on determining and fetching the correct firmware. This patch introduces intel_sanitize_uc_params() that is called from intel_uc_init(). Then, if we have GuC, we can call intel_guc_init() conditionally and we do not have to do internal checks. It can be easily extended