Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Daniel Vetter
On Mon, Dec 1, 2014 at 6:35 PM, Jani Nikula wrote: >>> Would it be just as easy to construct a scenario that had an infroframe >>> change that didn't get applied with the revert? Besides which a full >>> modeset on every pan should be good motiviation to make them nonblocking >>> (or at least use

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jani Nikula
On Mon, 01 Dec 2014, Daniel Vetter wrote: > On Mon, Dec 01, 2014 at 04:37:41PM +, Chris Wilson wrote: >> On Mon, Dec 01, 2014 at 05:30:41PM +0100, Daniel Vetter wrote: >> > On Mon, Dec 01, 2014 at 04:09:07PM +, Chris Wilson wrote: >> > > On Mon, Dec 01, 2014 at 08:04:30AM -0800, Jesse Barn

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jesse Barnes
On Mon, 1 Dec 2014 17:16:25 +0100 Daniel Vetter wrote: > On Mon, Dec 01, 2014 at 12:25:45PM +0200, Jani Nikula wrote: > > On Thu, 06 Nov 2014, Jesse Barnes wrote: > > > If these change (e.g. after a modeset following a fastboot), we need to > > > do a full mode set. > > > > > > v2: > > > - put

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Daniel Vetter
On Mon, Dec 01, 2014 at 04:37:41PM +, Chris Wilson wrote: > On Mon, Dec 01, 2014 at 05:30:41PM +0100, Daniel Vetter wrote: > > On Mon, Dec 01, 2014 at 04:09:07PM +, Chris Wilson wrote: > > > On Mon, Dec 01, 2014 at 08:04:30AM -0800, Jesse Barnes wrote: > > > > On Mon, 01 Dec 2014 12:25:45 +

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Chris Wilson
On Mon, Dec 01, 2014 at 05:30:41PM +0100, Daniel Vetter wrote: > On Mon, Dec 01, 2014 at 04:09:07PM +, Chris Wilson wrote: > > On Mon, Dec 01, 2014 at 08:04:30AM -0800, Jesse Barnes wrote: > > > On Mon, 01 Dec 2014 12:25:45 +0200 > > > Jani Nikula wrote: > > > > > > > On Thu, 06 Nov 2014, Jes

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Daniel Vetter
On Mon, Dec 01, 2014 at 04:09:07PM +, Chris Wilson wrote: > On Mon, Dec 01, 2014 at 08:04:30AM -0800, Jesse Barnes wrote: > > On Mon, 01 Dec 2014 12:25:45 +0200 > > Jani Nikula wrote: > > > > > On Thu, 06 Nov 2014, Jesse Barnes wrote: > > > > If these change (e.g. after a modeset following a

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Daniel Vetter
On Mon, Dec 01, 2014 at 12:25:45PM +0200, Jani Nikula wrote: > On Thu, 06 Nov 2014, Jesse Barnes wrote: > > If these change (e.g. after a modeset following a fastboot), we need to > > do a full mode set. > > > > v2: > > - put under pipe_config check so we don't deref a null state (Jesse) > > > >

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Chris Wilson
On Mon, Dec 01, 2014 at 08:04:30AM -0800, Jesse Barnes wrote: > On Mon, 01 Dec 2014 12:25:45 +0200 > Jani Nikula wrote: > > > On Thu, 06 Nov 2014, Jesse Barnes wrote: > > > If these change (e.g. after a modeset following a fastboot), we need to > > > do a full mode set. > > > > > > v2: > > > -

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jesse Barnes
On Mon, 01 Dec 2014 12:25:45 +0200 Jani Nikula wrote: > On Thu, 06 Nov 2014, Jesse Barnes wrote: > > If these change (e.g. after a modeset following a fastboot), we need to > > do a full mode set. > > > > v2: > > - put under pipe_config check so we don't deref a null state (Jesse) > > > > Sign

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jani Nikula
On Thu, 06 Nov 2014, Jesse Barnes wrote: > If these change (e.g. after a modeset following a fastboot), we need to > do a full mode set. > > v2: > - put under pipe_config check so we don't deref a null state (Jesse) > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c |

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-11-10 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira On 11/06/2014 12:26 AM, Jesse Barnes wrote: > If these change (e.g. after a modeset following a fastboot), we need to > do a full mode set. > > v2: >- put under pipe_config check so we don't deref a null state (Jesse) > > Signed-off-by: Jesse Barnes

[Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-11-05 Thread Jesse Barnes
If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. v2: - put under pipe_config check so we don't deref a null state (Jesse) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 12 +++- 1 file changed, 11 insertions(+), 1 dele