Re: [Intel-gfx] [PATCH 4/8] drm/i915: Retry HDCP BKSV read

2018-02-02 Thread Sean Paul
On Fri, Feb 02, 2018 at 07:56:22PM +0530, Ramalingam C wrote: > > > On Friday 02 February 2018 07:46 PM, Sean Paul wrote: > > On Fri, Feb 02, 2018 at 04:15:16PM +0530, Ramalingam C wrote: > > > When BKSV is invalid, to mitigate any communication errors, > > > BKSV is read once again. > > Why is t

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Retry HDCP BKSV read

2018-02-02 Thread Ramalingam C
On Friday 02 February 2018 07:46 PM, Sean Paul wrote: On Fri, Feb 02, 2018 at 04:15:16PM +0530, Ramalingam C wrote: When BKSV is invalid, to mitigate any communication errors, BKSV is read once again. Why is the Bksv read any more volatile than other reads? If the channel is noisy, the retrie

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Retry HDCP BKSV read

2018-02-02 Thread Sean Paul
On Fri, Feb 02, 2018 at 04:15:16PM +0530, Ramalingam C wrote: > When BKSV is invalid, to mitigate any communication errors, > BKSV is read once again. Why is the Bksv read any more volatile than other reads? If the channel is noisy, the retries should be done in the shim implementation (I think th

[Intel-gfx] [PATCH 4/8] drm/i915: Retry HDCP BKSV read

2018-02-02 Thread Ramalingam C
When BKSV is invalid, to mitigate any communication errors, BKSV is read once again. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel