Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-09 Thread Daniel Vetter
On Sat, Aug 9, 2014 at 3:21 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 9 Aug 2014, Rafael J. Wysocki wrote: Well it works currently. So where do you see the problem? Sampling registers from an timer - in particular, we really do not want to disable runtime pm whilst

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-09 Thread Rafael J. Wysocki
On Saturday, August 09, 2014 10:53:03 AM Daniel Vetter wrote: On Sat, Aug 9, 2014 at 3:21 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 9 Aug 2014, Rafael J. Wysocki wrote: Well it works currently. So where do you see the problem? Sampling registers from an timer - in

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Chris Wilson
On Tue, Jul 29, 2014 at 12:26:36PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 08:37:48AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 10:54:06AM +0200, Daniel Vetter wrote: On Sat, Jul 26, 2014 at 11:27:38AM +0100, Chris Wilson wrote: On Wed, Jun 18, 2014 at 10:54:13PM

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Daniel Vetter
On Fri, Aug 08, 2014 at 10:20:40AM +0100, Chris Wilson wrote: On Tue, Jul 29, 2014 at 12:26:36PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 08:37:48AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 10:54:06AM +0200, Daniel Vetter wrote: On Sat, Jul 26, 2014 at 11:27:38AM

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Greg KH
On Fri, Aug 08, 2014 at 11:37:01AM +0200, Daniel Vetter wrote: On Fri, Aug 08, 2014 at 10:20:40AM +0100, Chris Wilson wrote: On Tue, Jul 29, 2014 at 12:26:36PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 08:37:48AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 10:54:06AM

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Rafael J. Wysocki
On Friday, August 08, 2014 11:37:01 AM Daniel Vetter wrote: On Fri, Aug 08, 2014 at 10:20:40AM +0100, Chris Wilson wrote: On Tue, Jul 29, 2014 at 12:26:36PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 08:37:48AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 10:54:06AM +0200,

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Rafael J. Wysocki
On Friday, August 08, 2014 06:41:10 AM Greg KH wrote: On Fri, Aug 08, 2014 at 11:37:01AM +0200, Daniel Vetter wrote: On Fri, Aug 08, 2014 at 10:20:40AM +0100, Chris Wilson wrote: On Tue, Jul 29, 2014 at 12:26:36PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 08:37:48AM +0100,

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-08-08 Thread Alan Stern
On Sat, 9 Aug 2014, Rafael J. Wysocki wrote: Well it works currently. So where do you see the problem? Sampling registers from an timer - in particular, we really do not want to disable runtime pm whilst trying to monitor the impact of runtime pm. In that case you can grab a

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-07-29 Thread Chris Wilson
On Mon, Jul 28, 2014 at 10:54:06AM +0200, Daniel Vetter wrote: On Sat, Jul 26, 2014 at 11:27:38AM +0100, Chris Wilson wrote: On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.ma...@intel.com wrote: From: Oscar Mateo

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-07-29 Thread Daniel Vetter
On Tue, Jul 29, 2014 at 08:37:48AM +0100, Chris Wilson wrote: On Mon, Jul 28, 2014 at 10:54:06AM +0200, Daniel Vetter wrote: On Sat, Jul 26, 2014 at 11:27:38AM +0100, Chris Wilson wrote: On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 04:38:03PM

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-07-28 Thread Daniel Vetter
On Sat, Jul 26, 2014 at 11:27:38AM +0100, Chris Wilson wrote: On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.ma...@intel.com wrote: From: Oscar Mateo oscar.ma...@intel.com Or with a spinlock grabbed, because it might

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-07-26 Thread Chris Wilson
On Wed, Jun 18, 2014 at 10:54:13PM +0200, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.ma...@intel.com wrote: From: Oscar Mateo oscar.ma...@intel.com Or with a spinlock grabbed, because it might sleep, which is not a nice thing to do. Instead, do the runtime_pm

Re: [Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-06-18 Thread Daniel Vetter
On Fri, Jun 13, 2014 at 04:38:03PM +0100, oscar.ma...@intel.com wrote: From: Oscar Mateo oscar.ma...@intel.com Or with a spinlock grabbed, because it might sleep, which is not a nice thing to do. Instead, do the runtime_pm get/put together with the create/destroy request, and handle the

[Intel-gfx] [PATCH 45/53] drm/i915/bdw: Do not call intel_runtime_pm_get() in an interrupt

2014-06-13 Thread oscar . mateo
From: Oscar Mateo oscar.ma...@intel.com Or with a spinlock grabbed, because it might sleep, which is not a nice thing to do. Instead, do the runtime_pm get/put together with the create/destroy request, and handle the forcewake get/put directly. Signed-off-by: Oscar Mateo oscar.ma...@intel.com